ryan/chore
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects 5 Releases Wiki Activity

Add end-to-end tests for task modification and assignment features
All checks were successful
Chore App Build, Test, and Push Docker Images / build-and-push (push) Successful in 3m33s
Details

Browse Source 
- Implemented tests for editing penalty points and reward costs in `penalty-edit-points.spec.ts` and `reward-edit-cost.spec.ts`.
- Created detailed plans for task activation and assignment scenarios in `task-activated.plan.md` and `task-assignment.plan.md`.
- Added comprehensive test cases for modifying tasks, including editing points for chores, kindness acts, penalties, and rewards in `task-modified.plan.md`.
- Ensured all tests are isolated and run in serial mode to maintain state integrity.
This commit is contained in:
Ryan Kegel
2026-03-17 22:46:27 -04:00
parent b2115ceb57
commit a9131242a7
28 changed files with 3724 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

72
frontend/vue-app/e2e/plans/task-activated.plan.md Normal file
View File

@@ -0,0 +1,72 @@
# Parent Activate Task Points, and Reward Redemption, Flow
## Application Overview
In parent mode, with a populated list of chores, kindness acts, penalties, and rewards, tests must be run to activate tasks to give a child points, and redeem rewards (remove child points.)
- When the parent activates a chore, a confimation box should appear. Both "Yes" and "Cancel" should be tested. "Yes" will give points to the child. The activated chore should then be disabled and showing the text "Completed" If this chore is activated again, nothing happens.
- When the parent activates a kindness act, a confimation box should appear. Both "Yes" and "Cancel" should be tested. "Yes" will give points to the child. Kindness acts can be activated more than once.
- When the parent activates a negitive task (penalty), a confimation box should appear. Both "Yes" and "Cancel" should be tested. "Yes" will remove points from the child. The points can not be negitive. Penalties can be activated more than once.
- A reward can show how many more points are required to redeem the reward. If a parent activates in this state, nothing happens. When a point can be redeemed, it will have a green text stating that it can be redeemed. When a parent activates this a confirmation dialog appears. Both "Yes" and "Cancel" should be tested. "Yes" removes points from the child. This will cause the rewards status text to be changed in most cases to show how many points are required to redeem.
- Flow: The rows for chores, kindness acts, penalties, and rewards are scrollable. If there are many items in a row, the user can scroll through them.
- Activation: Activation happens with 2 clicks. The first click will center an item in the scroll box, and the next click will activate the item.
- Kebab and Edit button: When a chore is clicked, the top right of the chore will show a kebab icon, when the chore is activated or when somewhere else is clicked, that kebab menu will disappear. No need to test the kebab items yet. On kindness acts, penalties, and rewards, an edit icon will appear in the top right. The behavior is the same as the kebab menu. No need to test what the edit button does yet.
- Points will be displayed in a child card at the top of the screen, as well as the child's name, age, and profile icon.
---
## Implementation Status
All tests live in `e2e/mode_parent/task-activation/` and run under the `chromium-task-activation` Playwright project. **38 tests total — all passing.**
### chore-activation.spec.ts ✅
- Confirmation dialog appears on chore click
- Cancelling the dialog leaves points unchanged
- Confirming the dialog awards the chore's points to the child
- Completed chore shows "Completed" text and is disabled
- Clicking a completed chore a second time does nothing (no dialog, no extra points)
- Kebab menu disappears when a different chore card is clicked
### kindness-activation.spec.ts ✅
- Confirmation dialog appears on kindness act click
- Cancelling the dialog leaves points unchanged
- Confirming the dialog awards points and kindness acts can be triggered more than once (points accumulate)
- Edit button appears on the first click of a kindness card
- Edit button disappears when a different kindness card is clicked
### penalty-activation.spec.ts ✅
- Confirmation dialog appears on penalty click
- Cancelling the dialog leaves points unchanged
- Confirming the dialog deducts points from the child
- Points cannot go below zero (floor at 0)
- Penalties can be activated more than once
- Edit button disappears when a different penalty card is clicked
### reward-redemption.spec.ts ✅
- Reward shows a "points required" status when the child does not have enough points
- Clicking a non-redeemable reward opens no dialog (nothing happens)
- Reward shows a "REWARD READY" status when the child has enough points
- Edit button appears on the first click of a ready reward card
- Edit button disappears when a different reward card is clicked
- Cancelling the redemption dialog leaves points unchanged
- Confirming the dialog deducts the reward cost from the child's points and updates the status text
### scroll-and-flow.spec.ts ✅
- Kindness list is horizontally scrollable when many items are assigned (content width exceeds the viewport and the last card is off-screen)
- Scrolling the list reveals hidden items (last card enters the viewport; first card leaves it)
- First click on an off-screen item scrolls it into view and marks it ready (the `centerItem` animation completes and the card is visible within the viewport)
- Scrolling does not prevent first-click centering on a partially visible item (pre-scrolled list recenters on click)
### pending-reward-warning.spec.ts ✅
- Reward card shows a "PENDING" banner when a child has requested that reward
- Activating a chore while a reward is pending shows a warning dialog; cancelling leaves points and the pending request unchanged
- Activating a chore while a reward is pending shows a warning dialog; confirming cancels the pending request and proceeds to the normal task confirmation
- Activating a kindness act while a reward is pending shows a warning dialog; both cancel and confirm paths verified
- Activating a penalty while a reward is pending shows a warning dialog; both cancel and confirm paths verified
- Activating a different ready reward while a reward request is pending shows a warning dialog; cancelling preserves the pending request; confirming cancels it (the reward confirm dialog does not auto-open — the user must re-click)

149
frontend/vue-app/e2e/plans/task-assignment.plan.md Normal file
View File

@@ -0,0 +1,149 @@
# Parent Assign Chores, Kindness Acts, Penalties, and Rewards to a Child
## Application Overview
Tests for the parent-mode flows where a parent assigns task items (chores, kindness acts, penalties) and rewards to a specific child. Each suite navigates from the child's ParentView (`/parent/:id`) to the relevant assign view and verifies that selections are saved and reflected back in the ParentView.
The parent is authenticated via stored auth state (`e2e/.auth/user.json`). Each spec creates its own test child and items via the API so it is fully isolated from parallel test projects that mutate seed data. All created resources are deleted in `afterAll`. Tests run in `serial` mode within each suite to preserve assignment state across the sequence.
## Playwright Project
**Project name:** `chromium-task-assignment`
**Config:** `playwright.config.ts`
**testMatch:** `/mode_parent/task-assignment/.+\.spec\.ts/`
**Dependencies:** `setup`
**Excluded from:** `chromium-tasks-rewards` (via `testIgnore`)
---
## Test Scenarios
### 1. Chore Assignment ✅ IMPLEMENTED
**File:** `e2e/mode_parent/task-assignment/chore-assignment.spec.ts`
**Seed:** Creates child `AssignChoreChild` and tasks `AssignTestChore1/2/3` (type `chore`) via API in `beforeAll`. Deletes all in `afterAll`.
#### 1.1. "Assign Chores" button navigates to the chore assign view ✅
- Click `Assign Chores` from the child's ParentView
- expect: navigates to `/parent/:id/assign-chores` with the heading and test chores listed; nothing pre-checked on a fresh child
#### 1.2. Select chores and submit — items appear in ParentView ✅
- Select `AssignTestChore1` and `AssignTestChore2`, click `Submit`
- expect: returns to ParentView; both chores are visible
#### 1.3. Re-opening assign view shows assigned items as pre-checked ✅
- Navigate back to the assign-chores view
- expect: `AssignTestChore1` and `AssignTestChore2` are pre-checked; `AssignTestChore3` is not
#### 1.4. Uncheck all chores and submit — items are removed from ParentView ✅
- Uncheck both assigned chores, click `Submit`
- expect: returns to ParentView; neither chore is visible
#### 1.5. Cancel does not persist selection changes ✅
- Check `AssignTestChore3`, click `Cancel`, then navigate back to the view
- expect: `AssignTestChore3` is still unchecked
---
### 2. Kindness Act Assignment ✅ IMPLEMENTED
**File:** `e2e/mode_parent/task-assignment/kindness-assignment.spec.ts`
**Seed:** Creates child `AssignKindnessChild` and task `AssignTestKindness1` (type `kindness`) via API in `beforeAll`. Deletes all in `afterAll`.
#### 2.1. "Assign Kindness Acts" button navigates to the kindness assign view ✅
- Click `Assign Kindness Acts` from the child's ParentView
- expect: navigates to `/parent/:id/assign-kindness` with the heading and `AssignTestKindness1` listed and unchecked
#### 2.2. Select a kindness act and submit — item appears in ParentView ✅
- Select `AssignTestKindness1`, click `Submit`
- expect: returns to ParentView; item is visible
#### 2.3. Re-opening assign view shows the assigned item as pre-checked ✅
- Navigate back to the assign-kindness view
- expect: `AssignTestKindness1` is pre-checked
#### 2.4. Uncheck the kindness act and submit — item is removed from ParentView ✅
- Uncheck `AssignTestKindness1`, click `Submit`
- expect: returns to ParentView; item is no longer visible
#### 2.5. Cancel does not persist selection changes ✅
- Check `AssignTestKindness1`, click `Cancel`, then navigate back to the view
- expect: `AssignTestKindness1` is still unchecked
---
### 3. Penalty Assignment ✅ IMPLEMENTED
**File:** `e2e/mode_parent/task-assignment/penalty-assignment.spec.ts`
**Seed:** Creates child `AssignPenaltyChild` and tasks `AssignTestPenalty1/2/3` (type `penalty`) via API in `beforeAll`. Deletes all in `afterAll`.
#### 3.1. "Assign Penalties" button navigates to the penalty assign view ✅
- Click `Assign Penalties` from the child's ParentView
- expect: navigates to `/parent/:id/assign-penalties` with the heading and test penalties listed and unchecked
#### 3.2. Select penalties and submit — items appear in ParentView ✅
- Select `AssignTestPenalty1` and `AssignTestPenalty2`, click `Submit`
- expect: returns to ParentView; both penalties are visible
#### 3.3. Re-opening assign view shows assigned penalties as pre-checked ✅
- Navigate back to the assign-penalties view
- expect: `AssignTestPenalty1` and `AssignTestPenalty2` are pre-checked; `AssignTestPenalty3` is not
#### 3.4. Uncheck all penalties and submit — items are removed from ParentView ✅
- Uncheck both assigned penalties, click `Submit`
- expect: returns to ParentView; neither penalty is visible
#### 3.5. Cancel does not persist selection changes ✅
- Check `AssignTestPenalty3`, click `Cancel`, then navigate back to the view
- expect: `AssignTestPenalty3` is still unchecked
---
### 4. Reward Assignment ✅ IMPLEMENTED
**File:** `e2e/mode_parent/task-assignment/reward-assignment.spec.ts`
**Seed:** Creates child `AssignRewardChild` and rewards `AssignTestReward1/2/3` (cost 10) via API in `beforeAll`. Deletes all in `afterAll`.
#### 4.1. "Assign Rewards" button navigates to the reward assign view ✅
- Click `Assign Rewards` from the child's ParentView
- expect: navigates to `/parent/:id/assign-rewards` with the heading and test rewards listed and unchecked
#### 4.2. Select rewards and submit — items appear in ParentView ✅
- Select `AssignTestReward1` and `AssignTestReward2`, click `Submit`
- expect: returns to ParentView; both rewards are visible
#### 4.3. Re-opening assign view shows assigned rewards as pre-checked ✅
- Navigate back to the assign-rewards view
- expect: `AssignTestReward1` and `AssignTestReward2` are pre-checked; `AssignTestReward3` is not
#### 4.4. Uncheck all rewards and submit — items are removed from ParentView ✅
- Uncheck both assigned rewards, click `Submit`
- expect: returns to ParentView; neither reward is visible
#### 4.5. Cancel does not persist selection changes ✅
- Check `AssignTestReward3`, click `Cancel`, then navigate back to the view
- expect: `AssignTestReward3` is still unchecked

239
frontend/vue-app/e2e/plans/task-modified.plan.md Normal file
View File

@@ -0,0 +1,239 @@
# Parent Activate Modifies Task (changing points and resetting completed tasks)
## Application Overview
In parent mode, with a populated list of chores, kindness acts, penalties, and rewards, tests must be run to make sure a chore has a kebab menu that lets a parent make modifications to the chore. For kindness acts, penalties, and rewards, parents should be able to click on the edit button and change the amount of points or cost of the item.
This is a continuation of tests from task-assignment.plan.md
**Chores:**
- When the parent clicks on a chore's kebab menu, there should be an item that allows the parent to "Edit Points"
- When the parent clicks on a chore's kebab menu with the chore already in the COMPLETED state, there should be a "Reset" option.
- When a chore's "Edit Points" are clicked, a new dialog should appear with the chore's title, icon, and point value. These points should be editable. The value should not be negitive. If cancelled, nothing happens. If Save is clicked, the chore's point value should match what was entered. There should also be a star emoji that appears on the chore's card on the top right. The maximum value for the points should be 10000. Anything higher, the save button should disable.
- Clicking outside the points dialog should not close it. It should be modal.
- When the parent clicks "Reset" from a completed chore. That chore should become active again. The completed banner should be gone and the chore can be activated again.
- Everytime a resetted chore is activated it should go back to the completed state until reset again.
**Kindness Acts, Penalties, Rewards**
- When the parent clicks on these item's edit button, a new dialog should appear with the item's title, icon, and point/cost value. These points/costs should be editable. The value should not be negitive. If cancelled, nothing happens. If Save is clicked, the item's point value should match what was entered. There should also be a star emoji that appears on the chore's card on the top right. The maximum value for the points should be 10000. Anything higher, the save button should disable.
**Other Tests:**
When a point/cost value is changed, make sure the new value take affect when the parent activates the task. This testing is done in task-assignment.plan.md, but we want to verify the new point values work. There may be some test overlap.
---
## Implementation
Tests are in `e2e/mode_parent/task-modification/`. Each spec creates its own isolated child via the API so all 6 files run in parallel under the `chromium-task-modification` project.
## Playwright Project
**Project name:** `chromium-task-modification`
**Config:** `playwright.config.ts`
**testMatch:** `/mode_parent/task-modification/.+\.spec\.ts/`
**Dependencies:** `setup`
**Excluded from:** `chromium-tasks-rewards` (via `testIgnore`)
---
## Test Scenarios
### 1. Chore Edit Points ✅ IMPLEMENTED
**File:** `e2e/mode_parent/task-modification/chore-edit-points.spec.ts`
**Seed:** Creates an isolated child and a chore task via API in `beforeAll`. Deletes all in `afterAll`.
#### 1.1. Kebab button visibility ✅
- Kebab button is hidden initially; becomes visible after the chore card is clicked; hides again when a different card is clicked
#### 1.2. Kebab menu contents ✅
- Menu contains "Edit Points" and "Schedule" options
#### 1.3. Override modal opens pre-populated ✅
- "Edit Points" opens the override modal with the current point value already filled in
#### 1.4. Modal is blocking ✅
- Clicking outside the modal does not close it
#### 1.5. Cancel does not save ✅
- Card still shows original points after Cancel; no ⭐ badge appears
#### 1.6. Save updates displayed points ✅
- Saving a valid new value updates the point display on the card
#### 1.7. ⭐ override badge appears after save ✅
- ⭐ badge appears on the card after saving a custom value
#### 1.8. ⭐ badge persists on revert ✅
- ⭐ badge remains even when the value is changed back to the original default
#### 1.9. Validation — negative and over-limit ✅
- Negative value disables the Save button; value above 10000 disables Save; exactly 10000 enables it
#### 1.10. Zero is valid ✅
- Card shows "0 Points" with ⭐ badge when zero is saved
---
### 2. Chore Reset ✅ IMPLEMENTED
**File:** `e2e/mode_parent/task-modification/chore-reset.spec.ts`
**Seed:** Creates an isolated child and a chore task via API in `beforeAll`. Activates and confirms the chore as needed per test. Deletes all in `afterAll`.
#### 2.1. "Reset" absent before completion ✅
- "Reset" is not present in the kebab menu when the chore is not yet completed
#### 2.2. COMPLETED stamp after activation ✅
- Chore shows COMPLETED stamp after activation and parent confirmation
#### 2.3. "Reset" appears after completion ✅
- "Reset" appears in the kebab menu once the chore is in COMPLETED state
#### 2.4. Reset removes COMPLETED stamp ✅
- Clicking "Reset" removes the COMPLETED stamp and returns the chore to active
#### 2.5. Chore is re-activatable after reset ✅
- After reset, the chore can be activated again and returns to COMPLETED on confirmation
#### 2.6. Reset → activate cycle is repeatable ✅
- The reset and re-activate cycle can be repeated multiple times without error
---
### 3. Kindness Act Edit Points ✅ IMPLEMENTED
**File:** `e2e/mode_parent/task-modification/kindness-edit-points.spec.ts`
**Seed:** Creates an isolated child and two kindness act tasks via API in `beforeAll`. Deletes all in `afterAll`.
#### 3.1. Edit button visibility ✅
- Edit button appears on first click of a kindness card; disappears when a different card is clicked
#### 3.2. Override modal opens pre-populated ✅
- Edit button opens modal with the kindness name, "Assign new points" subtitle, and current point value filled in
#### 3.3. Cancel does not save ✅
- Points remain unchanged and no ⭐ badge appears after Cancel
#### 3.4. Save updates displayed points and badge ✅
- Saving a new value updates the displayed points and shows ⭐ badge
#### 3.5. Validation — negative and over-limit ✅
- Negative value disables the Save button; value above 10000 disables Save; exactly 10000 enables it
---
### 4. Penalty Edit Points ✅ IMPLEMENTED
**File:** `e2e/mode_parent/task-modification/penalty-edit-points.spec.ts`
**Seed:** Creates an isolated child and two penalty tasks via API in `beforeAll`. Deletes all in `afterAll`.
#### 4.1. Edit button visibility ✅
- Edit button appears on first click of a penalty card; disappears when a different card is clicked
#### 4.2. Override modal opens pre-populated ✅
- Edit button opens modal with the penalty name, "Assign new points" subtitle, and the raw (positive) point value filled in — not the negated display value
#### 4.3. Cancel does not save ✅
- Display remains unchanged after Cancel
#### 4.4. Save updates card and badge ✅
- Saving a new value updates the card to show the negated override value and ⭐ badge
#### 4.5. Validation — negative and over-limit ✅
- Negative value disables the Save button; value above 10000 disables Save; exactly 10000 enables it
---
### 5. Reward Edit Cost ✅ IMPLEMENTED
**File:** `e2e/mode_parent/task-modification/reward-edit-cost.spec.ts`
**Seed:** Creates an isolated child and a reward (with a pending redemption for warning-dialog tests) via API in `beforeAll`. Deletes all in `afterAll`.
#### 5.1. Edit button visibility ✅
- Edit button appears on first click of a reward card
#### 5.2. Override modal opens pre-populated ✅
- Edit button opens modal with the reward name, "Assign new cost" subtitle, and the current cost filled in
#### 5.3. Cancel does not save ✅
- Points needed display remains unchanged after Cancel
#### 5.4. Save updates cost and badge ✅
- Saving a new cost updates the points needed display and shows ⭐ badge
#### 5.5. Zero cost makes reward immediately redeemable ✅
- Setting cost to 0 marks the reward as immediately redeemable
#### 5.6. Validation — negative and over-limit ✅
- Negative value disables the Save button; value above 10000 disables Save; exactly 10000 enables it
#### 5.7. Warning dialog for pending redemption ✅
- Editing a reward with an active pending redemption shows a warning dialog; Cancel aborts the edit
#### 5.8. Confirming warning opens override modal ✅
- Confirming the warning dialog proceeds to open the override modal normally
---
### 6. Modified Points Take Effect on Activation ✅ IMPLEMENTED
**File:** `e2e/mode_parent/task-modification/modified-points-activation.spec.ts`
**Seed:** Creates an isolated child, a chore, a kindness act, a penalty, and a reward via API in `beforeAll`. Sets overrides for each. Deletes all in `afterAll`.
#### 6.1. Modified chore points awarded on activation ✅
- Child receives the overridden point value (not the default) when the chore is activated and confirmed
#### 6.2. Modified kindness points awarded on activation ✅
- Child receives the overridden point value when the kindness act is activated and confirmed
#### 6.3. Modified penalty points deducted on activation ✅
- Child loses the overridden point value when the penalty is applied
#### 6.4. Modified reward cost reflected in display ✅
- Points needed shown on the reward card reflects the overridden cost value