ryan
6b273c049c
- Implement anisotropic scaling for shape mounting to prevent distortion. - Replace bounding-box midpoint anchors with joint-based anchors for correct rotation. - Reset node transforms to ensure clean scaling and rotation before mounting shapes. - Introduce new helper functions for computing bounding boxes, anchors, part lengths, and scales. - Neutralize driver rotations to maintain a consistent frame of reference during shape mounting. - Update documentation to reflect changes and provide detailed bugfix specifications.
78 lines
5.7 KiB
Markdown
78 lines
5.7 KiB
Markdown
# Stickman Studio Bugs
|
|
|
|
## Stickman editor (Phase 5 Round 1)
|
|
|
|
### Snap to grid
|
|
|
|
1. The snap to grid menu item checkbox is still not populating with a check mark no matter how many times it is clicked.
|
|
|
|
### Shape copy and paste
|
|
|
|
1. The paste item in the context menu is only displaying if a shape is selected and the context menu is brought up. If I have an empty window OR if I don't have a shape selected in that window, 'paste' do not show up in the menu. It should show up as long as something is in the clipboard. Pasting into an empty window should be possible.
|
|
|
|
## Stickman editor (Phase 5 Round 2)
|
|
|
|
### Snap to grid
|
|
|
|
1. The snap to grid menu item checkbox is still not populating with a check mark. Should we come up with another solution for this?
|
|
|
|
### Object scaling after rotation
|
|
|
|
1. When I rotate an object to a different angle than the original (0) and the try to scale the object, the object returns back to 0 rotation and then begins to scale. The scale should happen while the object is rotated, and the object keeps that rotation while being scaled.
|
|
|
|
## Stickman editor (Phase 5 Round 3)
|
|
|
|
### Snap to grid
|
|
|
|
1. The snap to grid menu item checkbox is still not populating with a check mark. Let's change the implementation. _Propose an alternate solution_
|
|
|
|
### Pasting a shape
|
|
|
|
1. If an object has been scaled or rotated, and then the object's corresponding shape is deleted from a shape editor window - when a new shape is pasted, that shape takes on the scale, rotation, and position of the previous deleted shape or object had. When a shape is deleted, it's corrsponding object need to have it's position, rotation, and scale reset.
|
|
|
|
## Stickman editor (Phase 5 Round 4)
|
|
|
|
### Snap to grid when moving an object
|
|
|
|
1. Currently snapping to the grid snaps the mouse cursor to the grid, however, that can lead to object still not lining up properly. The object's bounding box should be what snaps to the grid. If a reference point is needed for snapping, use the object's upper left point of the bounding box.
|
|
|
|
## Stickman editor (Phase 6 Round 1)
|
|
|
|
### Seletion bounding box as well as rotation 'dot' should stay in front of all other objects.
|
|
|
|
If an object is selected, it's bounding box and rotation dot should be in front of all other objects.
|
|
|
|
### Touchpad panning is too slow
|
|
|
|
Panning using the touchpad does not moves too slowly. We need to increase the distance the panning moves through touchpad.
|
|
|
|
### Zooming in/out
|
|
|
|
When zooming in, we should use the mouse cursor as the zoom in point. If the cursor is in the window should determine where the zoom should happen.
|
|
|
|
## Stickman editor (Phase 7 Round 1)
|
|
|
|
### Silhouette starting position (or camera)
|
|
|
|
When starting the application, the silhouette stickman should be in the center of the view. Right now it starts on the left upper side of the view so the user has to pan over.
|
|
Either move the silhouette or the camera.
|
|
|
|
### Showing the pose guide
|
|
|
|
When clicking View->Show Pose Guide the guide toggles on and off, but the text never changes.
|
|
By default the pose is visible so the menu text should say "Hide Pose Guide"
|
|
When it is hidden it should say "Show Pose Guide"
|
|
|
|
### Guide visibility
|
|
|
|
The guide and joints should slightly 'ghost' in front of the objects so that the use can see how well the objects are aligned to the joints and limbs.
|
|
|
|
## Stickman editor (Phase 9 Round 1)
|
|
|
|
> FIXED — 2026 Round 1: implemented per docs/phase9_round1_bugfix_spec.md; anisotropic scaling, joint-based anchors, and node/driver transform neutralization; verified with a 37-assertion headless smoke test.
|
|
|
|
### Fix Shape Mount Math & Point Scaling in StkRigAdapter.gd
|
|
|
|
Problem Summary:
|
|
When applying .stk v1.4 data to master*rig.tscn, shapes are severely distorted:Giant Polygon Explosions (Legs): Uniformly scaling points using scale_factor = bone_length / part_length on both $X$ and $Y$ multiplies the shape's thickness, turning thin leg segments into screen-filling blocks.Misaligned Joint Rotations (Head/Torso): Using (min + max) / 2 sets the pivot to the geometric center of the shape instead of its joint connection (e.g., neck base or hip joint).Required Fixes in StkRigAdapter.gd (or ActorFactory.gd):Please refactor \_mount_shapes() / point calculation logic using the following rules:1. Anisotropic Scaling (Primary Axis Only)Do not apply scale_factor to both axes. Only scale points along the bone's primary directional axis; leave cross-axis thickness at a $1.0$ scale multiplier:Arms (Primary Axis: $X$):$$\text{point}*{\text{local}}.x = (P*x - \text{anchor}\_x) \times \left(\frac{\text{upper_arm_length}}{\text{part_length}}\right)$$$$\text{point}*{\text{local}}.y = P*y - \text{anchor}\_y$$Legs / Torso (Primary Axis: $Y$):$$\text{point}*{\text{local}}.x = P*x - \text{anchor}\_x$$$$\text{point}*{\text{local}}.y = (P*y - \text{anchor}\_y) \times \left(\frac{\text{upper_leg_length}}{\text{part_length}}\right)$$Head: Keep unscaled ($1.0$ factor) on both axes:$$\text{point}*{\text{local}} = P - \text{anchor}$$(Guard against division by zero if part_length <= 0 by defaulting the scale factor to 1.0.)2. Joint-Based Anchor Alignment (Not BBox Center)Replace bounding-box midpoint anchors with joint origins so shapes rotate correctly around the bone joints:Head Anchor: Bottom-center of bounding box (x = (min_x + max_x) / 2, y = max_y).Torso & Legs Anchor: Top-center of bounding box (x = (min_x + max_x) / 2, y = min_y).Arms Anchor: Joint-end connection (x = min_x for right arms, x = max_x for left arms, y = (min_y + max_y) / 2).3. Node Transform ResetEnsure target Body/\* container nodes have their local scale reset to Vector2(1, 1) and rotation = 0 so Godot's node hierarchy does not multiply the geometry scaling a second time.Deliverable:Please update StkRigAdapter.gd to implement these corrected coordinate transform calculations and return the full updated GDScript.
|